Change debugger type field back to "PowerShell" from powershell #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the debugger to start but not sure why powershell doesn't work. That said, the previous change meant that users would have to update their launch.json to change the type to "powershell". But even when I do that, the debugger still doesn't launch. So I'm a bit puzzled. But this gets the debugger working again on master. Also fixed some warnings in session.ts.
rkeithhill
commented
Feb 26, 2019
| @@ -411,8 +411,9 @@ export class SessionManager implements Middleware { | |||
| if (!this.suppressRestartPrompt && | |||
| (settings.useX86Host !== this.sessionSettings.useX86Host || | |||
| settings.powerShellExePath.toLowerCase() !== this.sessionSettings.powerShellExePath.toLowerCase() || | |||
| settings.developer.powerShellExePath.toLowerCase() !== | |||
| this.sessionSettings.developer.powerShellExePath.toLowerCase() || | |||
| (settings.developer.powerShellExePath ? settings.developer.powerShellExePath.toLowerCase() : null) !== | |||
There was a problem hiding this comment.
I really wish TypeScript had C#'s ?! operator.
rkeithhill
changed the title
TylerLeonhardt
approved these changes
Feb 26, 2019
|
I think this PR forgot these: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This allows the debugger to start but not sure why (lower-case) "powershell" doesn't
work. That said, the previous change meant that users would have to
update their launch.json to change the type to "powershell". But
even when I do that, the debugger still doesn't launch. So I'm a bit
puzzled. But this gets the debugger working again on master.
Also fixed some warnings in session.ts.
Fix #1768
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready